Changes [CHORE] 767 action sheet design changes #767 #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet.
adhiyan-tangoe
requested review from
jiaweicai92,
kpmurphh,
stolve and
swimtech20
adhiyan-tangoe
added
bug
swimtech20
reviewed
Oct 11, 2022
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
Show resolved
Hide resolved
jiaweicai92
previously approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@adhiyan-tangoe Code looks good. Some minor formatting issues. Please refer to @swimtech20 's comments
Code review suggestion changes
swimtech20
reviewed
Oct 12, 2022
projects/go-lib/src/lib/components/go-side-nav/go-side-nav/go-side-nav.component.scss
Outdated
Show resolved
Hide resolved
swimtech20
reviewed
Oct 12, 2022
Code review suggestion changes
swimtech20
approved these changes
Oct 13, 2022
|
@kpmurphh and myself have no way to provide approval/feedback for this issue. We do not have an instance of goponents on our systems in order to look at the visual fix and we are not in a position to give feedback on coding approaches. Please attach a screenshot of the update or block time on one of our calendars for a review session. |
RonMichaud
approved these changes
Mar 30, 2023
swimtech20
added a commit
that referenced
this pull request
Jun 9, 2023
* Update go-button.component.scss Changes for split button option text not to wrap and grow towards left. * GOP-877-BUG-minimum_height_for_textarea Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix. * Changes_bugfix_chore_task * alignment corrected for icon button css changes for button padding * codeclimate issue fix * Codeclimate fix * remove extra padding * Initial components and module interaction * Accordion_style changes Accordion styles Default Slim Dark * Changed dark theme * Changes [CHORE] 868 max height for toast Max height for the toast notification will not have an overflow unless specified. * Changes [CHORE] 767 action sheet design changes #767 1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet. * Update _forms.scss * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * Determinate and indeterminate progress bar * style update * Changes [CHORE] 868 max height for toast #890 1. Code review suggested changes. 2. Change in the code's header part in the documentation. * UT * safari styling fix * Fixing code climate issues * Changes [CHORE] 868 max height for toast #890 Code review suggested changes. * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * comment line message * clear code climate issues * code climate fix * dark theme color changes done * issue fixed * removed white spaces * BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE * ALIGNMENT AND NAMING CHANGES * Fix for duplicate modal and offcanvas content * ALIGNMENT_CHANGES * removing whitespace * Re-run Checks * Re-run Checks * Increasing test coverage * Update github src * GOP-807 empty checkin to trigger build * Fix select all filtered list (#914) * bug fixes for select all filtered list * single item, add remove handled * handling controls initial value incase of typeahead provided * changes in handling controls initial value * small condition fix * test cases updated and condition change in init control value * formatting changes * formatting changes * edge case handled while removing selected item * formatting changes * adding count to select all * adding count to select all * linting errors fixed * typo fixed * refactored code for better understanding * refactoring * lint fix * indentation changes, private methods and variables grouped, minor ux changes * renaming methods * karma config thresold changes --------- Co-authored-by: Vishal Shah <[email protected]> * v1.16.0 (#915) * Incrementing minor version Changes were made to upgrade "select all filter list" * Fixing patch version to be 0 Forgot to do this before... --------- Co-authored-by: sudheepdivakargithub <[email protected]> Co-authored-by: adhiyan-tangoe <[email protected]> Co-authored-by: Saravanan Muralidharan <[email protected]> Co-authored-by: Pooja-kj <[email protected]> Co-authored-by: Vijeta7 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: RonMichaud <[email protected]> Co-authored-by: Vishal Shah <[email protected]>
swimtech20
added a commit
that referenced
this pull request
Jan 5, 2024
* Update go-button.component.scss Changes for split button option text not to wrap and grow towards left. * GOP-877-BUG-minimum_height_for_textarea Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix. * Changes_bugfix_chore_task * alignment corrected for icon button css changes for button padding * codeclimate issue fix * Codeclimate fix * remove extra padding * Initial components and module interaction * Accordion_style changes Accordion styles Default Slim Dark * Changed dark theme * Changes [CHORE] 868 max height for toast Max height for the toast notification will not have an overflow unless specified. * Changes [CHORE] 767 action sheet design changes #767 1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet. * Update _forms.scss * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * Determinate and indeterminate progress bar * style update * Changes [CHORE] 868 max height for toast #890 1. Code review suggested changes. 2. Change in the code's header part in the documentation. * UT * safari styling fix * Fixing code climate issues * Changes [CHORE] 868 max height for toast #890 Code review suggested changes. * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * comment line message * clear code climate issues * code climate fix * dark theme color changes done * issue fixed * removed white spaces * BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE * ALIGNMENT AND NAMING CHANGES * Fix for duplicate modal and offcanvas content * ALIGNMENT_CHANGES * removing whitespace * Re-run Checks * Re-run Checks * Increasing test coverage * Update github src * GOP-807 empty checkin to trigger build * Fix select all filtered list (#914) * bug fixes for select all filtered list * single item, add remove handled * handling controls initial value incase of typeahead provided * changes in handling controls initial value * small condition fix * test cases updated and condition change in init control value * formatting changes * formatting changes * edge case handled while removing selected item * formatting changes * adding count to select all * adding count to select all * linting errors fixed * typo fixed * refactored code for better understanding * refactoring * lint fix * indentation changes, private methods and variables grouped, minor ux changes * renaming methods * karma config thresold changes --------- Co-authored-by: Vishal Shah <[email protected]> * v1.16.0 (#915) * Incrementing minor version Changes were made to upgrade "select all filter list" * Fixing patch version to be 0 Forgot to do this before... * #918 enhancement of go-date-picker * #918 - enhance go-date-picker * Added inout property to control the visibility of go-form-error. Implemented in all controls with go-form-error. * updated the documentation. * Rearranged the property * Used single quote instead of double quotes. * Added few more tests * #918 - Added test cases * Added app-drawer stylings * Fixed code climate lint errors. * Fixed code climate lint errors. * Fixed code climate lint errors. * Fixed code climate lint errors. * Update CSS for Drodown and add test cases * add few test cases based on background color * Add some more test cases for disable color * Resolve build issue and update test cases * Resolve code coverage issue and add few more test cases * Update test cases for enable and disable color for dropdown * Updating version number to reflect recent changes --------- Co-authored-by: sudheepdivakargithub <[email protected]> Co-authored-by: adhiyan-tangoe <[email protected]> Co-authored-by: Saravanan Muralidharan <[email protected]> Co-authored-by: Pooja-kj <[email protected]> Co-authored-by: Vijeta7 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: RonMichaud <[email protected]> Co-authored-by: Vishal Shah <[email protected]> Co-authored-by: Sinchana <[email protected]> Co-authored-by: CORP\Sudheep.Divakar <[email protected]> Co-authored-by: Amit Patra <[email protected]> Co-authored-by: ankit-tangoe <[email protected]>
swimtech20
added a commit
that referenced
this pull request
Mar 19, 2024
…sion and easier history tracking) (#940) * Update go-button.component.scss Changes for split button option text not to wrap and grow towards left. * GOP-877-BUG-minimum_height_for_textarea Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix. * Changes_bugfix_chore_task * alignment corrected for icon button css changes for button padding * codeclimate issue fix * Codeclimate fix * remove extra padding * Initial components and module interaction * Accordion_style changes Accordion styles Default Slim Dark * Changed dark theme * Changes [CHORE] 868 max height for toast Max height for the toast notification will not have an overflow unless specified. * Changes [CHORE] 767 action sheet design changes #767 1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet. * Update _forms.scss * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * Determinate and indeterminate progress bar * style update * Changes [CHORE] 868 max height for toast #890 1. Code review suggested changes. 2. Change in the code's header part in the documentation. * UT * safari styling fix * Fixing code climate issues * Changes [CHORE] 868 max height for toast #890 Code review suggested changes. * Changes [CHORE] 767 action sheet design changes #891 Code review suggestion changes * comment line message * clear code climate issues * code climate fix * dark theme color changes done * issue fixed * removed white spaces * BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE * ALIGNMENT AND NAMING CHANGES * Fix for duplicate modal and offcanvas content * ALIGNMENT_CHANGES * removing whitespace * Re-run Checks * Re-run Checks * Increasing test coverage * Update github src * GOP-807 empty checkin to trigger build * Fix select all filtered list (#914) * bug fixes for select all filtered list * single item, add remove handled * handling controls initial value incase of typeahead provided * changes in handling controls initial value * small condition fix * test cases updated and condition change in init control value * formatting changes * formatting changes * edge case handled while removing selected item * formatting changes * adding count to select all * adding count to select all * linting errors fixed * typo fixed * refactored code for better understanding * refactoring * lint fix * indentation changes, private methods and variables grouped, minor ux changes * renaming methods * karma config thresold changes --------- Co-authored-by: Vishal Shah <[email protected]> * v1.16.0 (#915) * Incrementing minor version Changes were made to upgrade "select all filter list" * Fixing patch version to be 0 Forgot to do this before... * #918 enhancement of go-date-picker * #918 - enhance go-date-picker * Added inout property to control the visibility of go-form-error. Implemented in all controls with go-form-error. * updated the documentation. * Rearranged the property * Used single quote instead of double quotes. * Added few more tests * #918 - Added test cases * Added app-drawer stylings * Fixed code climate lint errors. * Fixed code climate lint errors. * Fixed code climate lint errors. * Fixed code climate lint errors. * Update CSS for Drodown and add test cases * add few test cases based on background color * Add some more test cases for disable color * Resolve build issue and update test cases * Resolve code coverage issue and add few more test cases * Update test cases for enable and disable color for dropdown * Updating version number to reflect recent changes * Selecting date as 29 Feb for any of the date fields is throwing error across the modules (#936) * FEB_29th_selection * #GOCLD 2298 test cases * #GOCLD 2298 test cases * #GOCLD 2298 test cases * Update Goponent version (#937) Includes Leap Day calculations fix. * Update minor version for release (#939) * Update to major version release For easier history tracking/bug fixing. Noticed there were several file changes (1 commit) in main but not in dev... thoughts are this is related to the Activity Manager feature Persistent worked on in 2022-2023. * Making this a minor version update and not major Discussed with Jiawei --------- Co-authored-by: sudheepdivakargithub <[email protected]> Co-authored-by: adhiyan-tangoe <[email protected]> Co-authored-by: Saravanan Muralidharan <[email protected]> Co-authored-by: Pooja-kj <[email protected]> Co-authored-by: Vijeta7 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: RonMichaud <[email protected]> Co-authored-by: Vishal Shah <[email protected]> Co-authored-by: Sinchana <[email protected]> Co-authored-by: CORP\Sudheep.Divakar <[email protected]> Co-authored-by: Amit Patra <[email protected]> Co-authored-by: ankit-tangoe <[email protected]> Co-authored-by: preetigairi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Resolves #767
What is the new behavior?
Nunitowith light weight for the shell area.Does this PR introduce a breaking change?